Have we done this question before? I suspect we have, but maybe it's time for a recount. Last generation I think that the Xbox 360 controller was pretty much the undisputed champion but this time round? I think the contest is a little tighter.
On the side of the Xbox One -- sheer form factor, the weight, the addition of the extra rumble sensors. The Xbox One controller is an evolution of one of the best controllers ever designed, so it can't go wrong really.
The DualShock 4 has in its favour the shock of the new. It's such a dramatic improvement over its predecessor that it's hard not to fall in love with it. I love the new analogue sticks, I love the new shoulder buttons. I think the 'share' button is ingenious and I've been using it frequently. Compared to the Xbox One where the replacement to the 'Start/Back' buttons sort of don't really make sense.
But overall? It's a difficult contest to call. I think that, if I could choose I'd probably still prefer to play shooters on the Xbox One controller, by a hair. However, I might be inclined to say that I prefer the DualShock 4 overall.
Oh, I dunno. It's too tough. What do you think?